feat(k8s): integrate public_ip_disabled field
#2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
force-pushed
the
k8s_public_ip_disabled
branch
from
890cace to
b3c8f7e
Compare
Mia-Cross
force-pushed
the
k8s_public_ip_disabled
branch
from
b3c8f7e to
6e2cfd1
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2157 +/- ##
=======================================
Coverage 73.24% 73.25%
=======================================
Files 203 203
Lines 32146 32155 +9
=======================================
+ Hits 23546 23555 +9
Misses 6573 6573
Partials 2027 2027
☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The k8s API just got a new field
public_ip_disabledwhich allows users to choose if they want their pools to be given a public IP or not.It should be integrated to the
scaleway_k8s_poolresource.