Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance_server): detach pn on server deletion #2179

Merged

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Oct 20, 2023

Delete private-nic before server when managed by instance_server resource.
Useful for the workflow:

  • Delete Server
  • Delete PN

It would fail because the PN was not empty yet

@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Oct 20, 2023
@Codelax Codelax self-assigned this Oct 20, 2023
@Codelax Codelax marked this pull request as ready for review October 20, 2023 13:59
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d6150ef) 73.36% compared to head (a7a8b00) 73.32%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
- Coverage   73.36%   73.32%   -0.05%     
==========================================
  Files         212      212              
  Lines       33262    33292      +30     
==========================================
+ Hits        24403    24410       +7     
- Misses       6764     6788      +24     
+ Partials     2095     2094       -1     
Files Coverage Δ
scaleway/resource_instance_server.go 73.86% <40.00%> (-0.27%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Oct 23, 2023
Merged via the queue into scaleway:master with commit 71e160c Oct 23, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants