-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/type safety #1
base: master
Are you sure you want to change the base?
Conversation
Unfortunately this is little better than IRunner.Run
This reverts commit 12a300d.
Hi, I've not had time to look at your PR yet, but I will. Thank you for your effort in raising it. I was curious though, are you using Cycle.NET? |
Thanks for getting back. I haven't used it yet, but I'm getting ready to. I like the cycle.js architecture and I'm looking to use it with ReactiveUI in a MAUI app. Just wanted to give it some type safety before I got started. |
Although... I have given the thing some thought and I'm considering redoing this some. Particularly, I don't like that I've removed the original plain object version of the runner. Makes sense to have it so that folks who don't want the more rigorous type safe version have options. So I think I'm going to put a pause on this one so I can get that back in. |
Ok, I've readded the original runner but reimplemented it on top of the same runner "kernel" the type-safe runner uses. The original demo is left intact with a parallel type-safe comparison demo. Interested to hear your thoughts; I might try going through and implementing some of the cycle.js examples at some point... |
I'm sorry it's been so long since I replied. I'm really glad you're finding this useful though. I don't know if/when I'll get time to think about this properly, so I've added you as a collaborator and I'm happy for you to take this forward if you'd like to. |
Make the runner a little more type safe with generic sum types