Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Sprites Comment Attribute and allow comment duplication #5110

Closed

Conversation

Victor-Crawshaw
Copy link

Resolves

Resolves scratchfoundation/scratch-gui#3687

Proposed Changes

Create comment attribute in Sprite, and modify duplicate() method to copy over that comment attribute. Targets now take comments as an argument so that they may be copied over in Rendered Target as well.

Duplicate.Comments.Demo.mp4

Reason for Changes

Comments should be an attribute in Sprite because if comments want to be duplicated when sprites are duplicated, then it would make sense for them to be part of a sprite, rather than merely part of a target,

Test Coverage

Added unit test to ensure comments are duplicated along with a sprite, also made sure all other tests still pass.

Copy link

github-actions bot commented Dec 7, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
✅ (Victor-Crawshaw)[https://github.com/Victor-Crawshaw]
@John-Crawshaw
John-Crawshaw seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Victor-Crawshaw
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@Victor-Crawshaw
Copy link
Author

recheck

@Victor-Crawshaw Victor-Crawshaw closed this by deleting the head repository Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicated sprites lose their comments
2 participants