error_injection: replace boost::lexical_cast with std::from_chars #22164
Conversation
Replace boost with a standard facility; this reduces dependencies as lexical_cast depends on boost ranges.
🔴 CI State: FAILURE✅ - Build Failed Tests (2/35576):
Build Details:
|
|
🔴 CI State: FAILURE✅ - Build Build Details:
|
|
@yaronkaikov what can I do about the offline installer failures? |
It's scylladb/scylla-cluster-tests#9645 Generally, I think it's wrong to run them in CI. |
Well, just not long ago, we had a regression that took us a few months to fix. |
Run it nightly, or on next. Nor per PR. |
This is what we were doing, before (nightly) and it didn't help us much About running in |
| @@ -13,6 +13,7 @@ | |||
| #include <boost/range/adaptor/map.hpp> | |||
| #include <boost/range/algorithm/copy.hpp> | |||
| #include <boost/range/join.hpp> | |||
| #include <boost/lexical_cast.hpp> | |||
There was a problem hiding this comment.
Why not convert the error injection point in override_snapshot_thresholds too?
There was a problem hiding this comment.
Because I want to keep the patch localized and not grow it.
Ok with that. |
|
Docker test failed too. What can I do to make CI pass? |
It failed due to scylladb/scylla-cluster-tests#9645 @fruch any idea what is going on ? |
|
Since podman now supports nested containers, perhaps we can test the container image in test.py. |
those tests are not just for docker image... |
|
We can test other packages too in containers. |
🟢 CI State: SUCCESS✅ - Build Build Details:
|
Replace boost with a standard facility; this reduces dependencies as lexical_cast depends on boost ranges.
Small build time improvement, no backport needed.