Fix failed action attempt handling, add custom action attempt errors #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrii-balitskyi
commented
Jul 25, 2024
•
andrii-balitskyi
commented
- Move http errors to new seam/errors.rb
- Add action attempt errors and use them
- Correctly handle error action attempts
- Ensure default values for timeout and polling_interval are used in wait_until_finished
- Default wait_for_action_attempt client setting to true
- Fix error action attempt handling
- Add wait_for_action_attepmt_spec.rb
…it_until_finished
andrii-balitskyi
changed the title
andrii-balitskyi
changed the title
andrii-balitskyi
changed the title
razor-x
reviewed
Jul 29, 2024
andrii-balitskyi
force-pushed
the
action-attempt-error-handling
branch
2 times, most recently
from
7df4572 to
0e79fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.