Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom global key for Koala #2667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mshwery
Copy link
Contributor

@mshwery mshwery commented Jan 4, 2025

We've found some instances where customer code encounters conflicts with window.ko and we're modifying the install snippet to respect their custom globalKoalaKey.

Testing

Tested this version of the init script manually. Koala can load with a custom namespace when window.globalKoalaKey is set.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment joe-ayoub-segment self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants