Mx51 feature/uds support

.github/workflows/go.yml

@@ -0,0 +1,37 @@
+---
+name: Test
+"on":
+  - pull_request
+
+jobs:
+  test:
+    strategy:
+      matrix:
+        go:
+          - 'oldstable'
+          - 'stable'
+        label:
+          - [self-hosted, linux, arm64, segment]
+          - ubuntu-latest
+
+    runs-on: ${{ matrix.label }}
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Go (${{ matrix.go }})
+        uses: actions/setup-go@v5
+        with:
+          go-version: ${{ matrix.go }}
+
+      - name: Identify OS
+        run: uname -a
+
+      - name: Identify Go Version
+        run: go version
+
+      - name: Download Dependencies
+        run: go mod download
+
+      - name: Run Tests
+        run: go test -race -tags=${{ matrix.tags }} ./...

.github/workflows/golangci-lint.yml

@@ -0,0 +1,32 @@
+---
+name: golangci-lint
+"on":
+  push:
+    tags:
+      - v*
+    branches: [main]
+    paths:
+      - '**.go'
+      - .golangci.yml
+      - .github/workflows/golangci-lint.yml
+  pull_request:
+    branches:
+      - main
+
+
+jobs:
+  lint:
+    name: lint
+    runs-on: ubuntu-latest
+    continue-on-error: true
+    steps:
+      - uses: actions/setup-go@v5
+        with:
+          go-version: '>=1.20'
+
+      - uses: actions/checkout@v4
+
+      - name: golangci-lint
+        uses: golangci/[email protected]
+        with:
+          version: v1.59.1

.golangci.yml

@@ -0,0 +1,38 @@
+run:
+  deadline: 5m
+
+output:
+  sort-results: true
+
+linters:
+  disable:
+    - depguard  # this linter is broken in golangci-lint as of 2023-07-18.
+
+  enable:
+    - godot
+    - gofumpt
+    - goimports
+    - revive
+    - whitespace
+    - misspell
+
+issues:
+  exclude-files:
+    # Skip autogenerated files.
+    - ^.*\.(pb|y)\.go$
+  exclude-rules:
+    - path: _test.go
+      linters:
+        - errcheck
+
+linters-settings:
+  depguard:
+    list-type: blacklist
+    include-go-root: true
+    packages-with-error-message: []
+  goimports:
+    local-prefixes: github.com/segmentio/stats
+  gofumpt:
+    extra-rules: true
+  misspell:
+    locale: US

.otel/config.yaml

@@ -0,0 +1,28 @@
+receivers:
+  otlp:
+    protocols:
+      grpc:
+      http:
+        endpoint: 0.0.0.0:4318
+
+processors:
+  batch:
+
+exporters:
+  logging:
+    logLevel: debug
+
+  prometheus:
+    endpoint: "0.0.0.0:4319"
+
+service:
+  telemetry:
+    logs:
+      level: "debug"
+
+  pipelines:
+    metrics:
+      receivers: [otlp]
+      processors: []
+      exporters: [logging, prometheus]
+

README.md

@@ -6,7 +6,7 @@ Installation
 ------------
 
 ```
-go get github.com/segmentio/stats
+go get github.com/segmentio/stats/v4
 ```
 
 Migration to v4
@@ -30,7 +30,7 @@ type funcMetrics struct {
 ```go
 t := time.Now()
 f()
-callTime := time.Now().Sub(t)
+callTime := time.Since(t)
 
 m := &funcMetrics{}
 m.calls.count = 1
@@ -192,6 +192,7 @@ Statistics are collected for the current process and metrics including Goroutine
 count and memory usage are reported.
 
 Here's an example of how to use the collector:
+
 ```go
 package main
 
@@ -237,6 +238,7 @@ collection to a HTTP handler, reporting things like request processing time,
 error counters, header and body sizes...
 
 Here's an example of how to use the decorator:
+
 ```go
 package main
 
@@ -270,6 +272,7 @@ package exposes a decorator of `http.RoundTripper` which collects and reports
 metrics for client requests the same way it's done on the server side.
 
 Here's an example of how to use the decorator:
+
 ```go
 package main
 
@@ -298,6 +301,7 @@ func main() {
 
 You can also modify the default HTTP client to automatically get metrics for all
 packages using it, this is very convinient to get insights into dependencies.
+
 ```go
 package main
 
@@ -332,6 +336,7 @@ package exposes:
   which collects metrics for server requests.
 
 Here's an example of how to use the decorator on the client side:
+
 ```go
 package main
 

buckets.go

@@ -33,7 +33,7 @@ func makeKey(s string) Key {
 	return Key{Measure: measure, Field: field}
 }
 
-func splitMeasureField(s string) (measure string, field string) {
+func splitMeasureField(s string) (measure, field string) {
 	if i := strings.LastIndexByte(s, '.'); i >= 0 {
 		measure, field = s[:i], s[i+1:]
 	} else {

buffer.go

@@ -132,7 +132,7 @@ type Serializer interface {
 type buffer struct {
 	lock uint64
 	data []byte
-	pad  [32]byte // padding to avoid false sharing between threads
+	_    [32]byte // padding to avoid false sharing between threads
 }
 
 func (b *buffer) acquire() bool {
@@ -155,12 +155,8 @@ func (b *buffer) len() int {
 	return len(b.data)
 }
 
-func (b *buffer) cap() int {
-	return cap(b.data)
-}
-
 func (b *buffer) flush(w io.Writer, n int) {
-	w.Write(b.data[:n])
+	_, _ = w.Write(b.data[:n])
 	n = copy(b.data, b.data[n:])
 	b.data = b.data[:n]
 }

clock.go

@@ -6,6 +6,8 @@ import "time"
 //
 // Clocks are useful to measure the duration taken by sequential execution steps
 // and therefore aren't safe to be used concurrently by multiple goroutines.
+//
+// Note: Clock times are reported to datadog in seconds. See `stats/datadog/measure.go`.
 type Clock struct {
 	name  string
 	first time.Time

cmd/dogstatsd/main.go

@@ -48,7 +48,7 @@ commands:
 }
 
 func client(cmd string, args ...string) {
-	var fset = flag.NewFlagSet("dogstatsd "+cmd+" [options...] metric value [-- args...]", flag.ExitOnError)
+	fset := flag.NewFlagSet("dogstatsd "+cmd+" [options...] metric value [-- args...]", flag.ExitOnError)
 	var extra []string
 	var tags tags
 	var addr string
@@ -59,7 +59,7 @@ func client(cmd string, args ...string) {
 	args, extra = split(args, "--")
 	fset.StringVar(&addr, "addr", "localhost:8125", "The network address where a dogstatsd server is listening for incoming UDP datagrams")
 	fset.Var(&tags, "tags", "A comma-separated list of tags to set on the metric")
-	fset.Parse(args)
+	_ = fset.Parse(args)
 	args = fset.Args()
 
 	if len(args) == 0 {
@@ -74,17 +74,13 @@ func client(cmd string, args ...string) {
 			value = 1.0
 		} else if value, err = strconv.ParseFloat(args[0], 64); err != nil {
 			errorf("bad metric value: %s", args[0])
-		} else {
-			args = args[1:]
 		}
 
 	case "set":
 		if len(args) == 0 {
 			errorf("missing metric value")
 		} else if value, err = strconv.ParseFloat(args[0], 64); err != nil {
 			errorf("bad metric value: %s", args[0])
-		} else {
-			args = args[1:]
 		}
 	}
 
@@ -101,28 +97,28 @@ func client(cmd string, args ...string) {
 	case "time":
 		start := time.Now()
 		run(extra...)
-		stats.Observe(name, time.Now().Sub(start), tags...)
+		stats.Observe(name, time.Since(start), tags...)
 	}
 }
 
 func server(args ...string) {
-	var fset = flag.NewFlagSet("dogstatsd agent [options...]", flag.ExitOnError)
+	fset := flag.NewFlagSet("dogstatsd agent [options...]", flag.ExitOnError)
 	var bind string
 
 	fset.StringVar(&bind, "bind", ":8125", "The network address to listen on for incoming UDP datagrams")
-	fset.Parse(args)
+	_ = fset.Parse(args)
 	log.Printf("listening for incoming UDP datagram on %s", bind)
 
-	datadog.ListenAndServe(bind, handlers{})
+	_ = datadog.ListenAndServe(bind, handlers{})
 }
 
 type handlers struct{}
 
-func (h handlers) HandleMetric(m datadog.Metric, a net.Addr) {
+func (h handlers) HandleMetric(m datadog.Metric, _ net.Addr) {
 	log.Print(m)
 }
 
-func (h handlers) HandleEvent(e datadog.Event, a net.Addr) {
+func (h handlers) HandleEvent(e datadog.Event, _ net.Addr) {
 	log.Print(e)
 }
 
@@ -146,7 +142,7 @@ func errorf(msg string, args ...interface{}) {
 	os.Exit(1)
 }
 
-func split(args []string, sep string) (head []string, tail []string) {
+func split(args []string, sep string) (head, tail []string) {
 	if i := indexOf(args, sep); i < 0 {
 		head = args
 	} else {

context.go

@@ -33,7 +33,7 @@ func ContextAddTags(ctx context.Context, tags ...Tag) bool {
 }
 
 // ContextTags returns a copy of the tags on the context if they exist and nil
-// if they don't exist
+// if they don't exist.
 func ContextTags(ctx context.Context) []Tag {
 	if x := getTagSlice(ctx); x != nil {
 		x.lock.Lock()
@@ -62,12 +62,12 @@ type tagSlice struct {
 // for defining context keys was copied from Go 1.7's new use of context in net/http.
 type tagsKey struct{}
 
-// String is Stringer implementation
+// String implements the fmt.Stringer interface.
 func (k tagsKey) String() string {
 	return "stats_tags_context_key"
 }
 
-// contextKeyReqTags is contextKey for tags
+// contextKeyReqTags is contextKey for tags.
 var (
 	contextKeyReqTags = tagsKey{}
 )

context_test.go

@@ -17,7 +17,8 @@ func TestContextTags(t *testing.T) {
 	assert.Equal(t, 0, len(ContextTags(x)), "Original context should have no tags (because no context with key)")
 
 	// create a child context which creates a child context
-	z := context.WithValue(y, "not", "important")
+	type unimportant struct{}
+	z := context.WithValue(y, unimportant{}, "important")
 	assert.Equal(t, 1, len(ContextTags(z)), "We should still be able to see original tags")
 
 	// Add tags to the child context's reference to the original tag slice

datadog/append_test.go

@@ -4,7 +4,7 @@ import "testing"
 
 func TestAppendMetric(t *testing.T) {
 	for _, test := range testMetrics {
-		t.Run(test.m.Name, func(b *testing.T) {
+		t.Run(test.m.Name, func(t *testing.T) {
 			if s := string(appendMetric(nil, test.m)); s != test.s {
 				t.Errorf("\n<<< %#v\n>>> %#v", test.s, s)
 			}