stop flaky test failures (#159)

* add sleep to stop flaky test failures * remove unused import * fix sleep * fix retry instead of sleeping * improve checks * remove duplicate code * use one retry
segmentio · Oct 10, 2023 · a9fbfec · a9fbfec
1 parent 410aed6
commit a9fbfec
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/pkg/admin/brokerclient_test.go b/pkg/admin/brokerclient_test.go
@@ -455,10 +455,18 @@ func TestBrokerClientAlterAssignments(t *testing.T) {
 		topicInfo, err = client.GetTopic(ctx, topicName, true)
 		require.NoError(t, err)
 
+		// Alter partition succeeded
 		if topicInfo.Partitions[2].Replicas[0] != 5 {
 			return fmt.Errorf("Assign partitions change not reflected yet")
 		}
 
+		// ISR shrink completed
+		for _, partition := range topicInfo.Partitions {
+			if len(partition.Replicas) != 2 {
+				return fmt.Errorf("Assign partitions change not reflected yet")
+			}
+		}
+
 		return nil
 	})