Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to include internal topics in bootstrap #192

Merged
merged 3 commits into from
May 10, 2024

Conversation

dtjm
Copy link
Contributor

@dtjm dtjm commented May 10, 2024

  • We have a tool which runs topicctl bootstrap, then topicctl rebalance in succession.
  • With this approach we are currently unable to rebalance topics such as __consumer_offsets since they are explicitly not considered for bootstrap
  • This change will introduce a new flag which allows us to bootstrap these topic configurations.
  • The default will be to continue current behavior of skipping double-underscore topics.

Example usage

topicctl bootstrap --cluster-config=... --allow-internal-topics=true --output=./topics/

[2024-05-10 17:26:47]  INFO Writing config to topics/__amazon_msk_canary.yaml
[2024-05-10 17:26:47]  INFO Writing config to topics/__consumer_offsets.yaml
[2024-05-10 17:26:47]  INFO Writing config to topics/__strimzi-topic-operator-kstreams-topic-store-changelog.yaml
[2024-05-10 17:26:47]  INFO Writing config to topics/__strimzi_store_topic.yaml
[2024-05-10 17:26:47]  INFO Skipping over existing config topics/mp-events-userid.yaml

@dtjm dtjm requested a review from a team as a code owner May 10, 2024 17:14
@dtjm dtjm marked this pull request as draft May 10, 2024 17:16
@dtjm dtjm marked this pull request as ready for review May 10, 2024 18:31
@dtjm dtjm changed the title add ability to include double-underscore topics in bootstrap add ability to include internal topics in bootstrap May 10, 2024
Copy link
Contributor

@ssingudasu ssingudasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/cli/cli.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hhahn-tw hhahn-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@hhahn-tw hhahn-tw merged commit 12e49ad into master May 10, 2024
9 checks passed
@hhahn-tw hhahn-tw deleted the allow-underscored-topics branch May 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants