bug: substr fails to compile (ibis-project#94)

seibs · Nov 22, 2021 · 05012d5 · 05012d5
1 parent 86594aa
commit 05012d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/ibis_bigquery/compiler.py b/ibis_bigquery/compiler.py
@@ -291,7 +291,7 @@ def _string_substring(translator, expr):
         raise ValueError("Length parameter should not be a negative value.")
 
     base_substring = operation_registry[ops.Substring]
-    base_substring(translator, expr)
+    return base_substring(translator, expr)
 
 
 def _array_literal_format(expr):

diff --git a/tests/unit/test_compiler.py b/tests/unit/test_compiler.py
@@ -245,6 +245,16 @@ def test_binary():
 
 
 def test_substring():
+    t = ibis.table([("value", "string")], name="t")
+    expr = t["value"].substr(3, 1)
+    expected = """\
+SELECT substr(`value`, 3 + 1, 1) AS `tmp`
+FROM t"""
+    result = ibis_bigquery.compile(expr)
+
+    assert result == expected
+
+def test_substring_neg_length():
     t = ibis.table([("value", "string")], name="t")
     expr = t["value"].substr(3, -1)
     with pytest.raises(Exception) as exception_info: