-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add skipCi
option
#264
base: master
Are you sure you want to change the base?
Conversation
Can customize the way the "skip ci" information is passed to git
Hello, is there someone here ? @pvdlg are you still here ? |
I'm a big fan of this... hopefully it can be reviewed. |
Thanks, but I'm starting to lose hope |
@travi is this something that you'd be interested in? It looks like a great way to clean up the release message. |
Big fan of this feature. Any update ? |
@travi If you are interested I could probably rework this in a |
Anyone from @semantic-release interested in helping moving this feature forward? |
I don't use a git forge that supports |
@flaval I've taken the liberty of patching your fork (on my own fork). It supports opening up the push options to pass any option desired. e.g: {
...
[
"semantic-release-git",
{
"assets": [
"CHANGELOG.md"
],
"skipCi": {
"pushOption": "skip-ci"
}
}
],
...
} I also noticed the tests break if your git uses a default branch name besides As I'm unsure if this PR will get approved or merged (it's been years since @flaval opened this), I am installing this in my project (after updating some things in the package.json so there's no conflicts) and using the name
I've tested this on my own project and it works pretty great! Hope this helps anyone who needs it! 🙏 |
This PR add the ability to plugin's user to specify the way he wants to pass the "skip ci" information.
By default, the
[skip ci]
keyword is passed to the commit message, but this behavior is not always the required one. Worse, it is hard fixed to the default commit message, and the plugin's user have to copy/paste the default commit message omitting this keyword if he doesn't want it.This option permit to specify
message
value to keep the default behavior,pushOption
value to use the git "push-option" functionnality (a warning is raised in README about git version compliance) orfalse
to simply remove the keyword in default message.It answsers to a (already closed) issue #171.
Like I said in this issue, I'm not a really good english speaker/writer, so forgive my comment and please review my
README
updates. 😅Another thing, it is my very first contribution/PR on github, I hope I correctly follow the process 🙂