Retrieve link name from link when using link asset #401
Conversation
| if (!label) { | ||
| const parsedUrl = new URL(_url); | ||
| const file = pathlib.basename(parsedUrl.pathname); | ||
| _label = file ? file : 'Unknown asset'; |
There was a problem hiding this comment.
I don't like the fallback here. What about using parsedUrl.hostname?
Also can any of these throw an exception that we should handle?
There was a problem hiding this comment.
You mean replacing 'Unknown asset' by parsedUrl.hostname?
Actually I am thinking any better handling here too since the link name must be unique within the release.
So when user have urls like below will cause exception during publish
https://server1.com/1.txt
https://server2.com/1.txt
There was a problem hiding this comment.
We could include the index from .map, e.g.:
_label = file ? file : `${parsedUrl.hostname}_${index}`;
|
@awcjack Are you planning to continue here? If not just speak and I can finish it! |
Co-authored-by: Florian Greinacher <[email protected]>
Co-authored-by: Florian Greinacher <[email protected]>
Quite busy last week and forget the pull request 🙈 |
|
This PR has been stale for over a year now, so I'm closing it. Feel free to recreate if needed :) |
link name is required for link asset following documentation
If label property is not provided, try to retrieve the link name from url
Close #393