Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.2.49 #174

Merged
merged 4 commits into from
Jan 1, 2025
Merged

Rc 1.2.49 #174

merged 4 commits into from
Jan 1, 2025

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Dec 29, 2024

pyubx2 Pull Request Template

Description

  1. Enhance exception handling in val2bytes() to explicitly validate value type e.g.
...
TypeError: Attribute type X001 value 0 must be <class 'bytes'>, not <class 'int'>

Fixes #172 #173

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

If you're adding new UBX message definitions for Generation 9+ devices, please check for any corresponding configuration database updates (ubxtypes_configdb.py).

  • tests added to test_exceptions.py

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label Dec 29, 2024
@semuadmin semuadmin added this to the RC 1.2.49 milestone Dec 29, 2024
@semuadmin semuadmin self-assigned this Dec 29, 2024
@semuadmin semuadmin marked this pull request as draft December 29, 2024 20:19
@semuadmin semuadmin requested a review from a team December 29, 2024 20:19
@semuadmin semuadmin marked this pull request as ready for review January 1, 2025 08:40
@semuadmin semuadmin force-pushed the RC-1.2.49 branch 2 times, most recently from 9b66e40 to 502aec5 Compare January 1, 2025 08:53
@semuadmin semuadmin merged commit ec4ee76 into master Jan 1, 2025
@semuadmin semuadmin deleted the RC-1.2.49 branch January 1, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UBXMessage.config_set() throws TypeError for config item of X1 type
2 participants