Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update current application object struct #3041

Closed
wants to merge 1 commit into from
Closed

update current application object struct #3041

wants to merge 1 commit into from

Conversation

ivinjabraham
Copy link
Contributor

@ivinjabraham ivinjabraham commented Nov 15, 2024 •
edited
Loading

Application::CurrentApplicationInfo is out of date from the official docs

@github-actions github-actions bot added the model Related to the `model` module. label Nov 15, 2024
@ivinjabraham ivinjabraham force-pushed the update-current-application-info branch from 07699f6 to 5393a8b Compare November 15, 2024 14:35
jamesbt365
jamesbt365 requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are changing public fields, so this is a breaking change. Breaking changes must target next.

@ivinjabraham ivinjabraham changed the base branch from current to next November 15, 2024 14:39
@ivinjabraham ivinjabraham force-pushed the update-current-application-info branch from 5393a8b to 92c23e1 Compare November 15, 2024 14:54
@ivinjabraham
Copy link
Contributor Author

Alright done, I'll rebase #3035 to next as well then

@ivinjabraham ivinjabraham force-pushed the update-current-application-info branch from 92c23e1 to 3cf7756 Compare November 17, 2024 12:22
@ivinjabraham ivinjabraham mentioned this pull request Nov 17, 2024
Open
@ivinjabraham
Copy link
Contributor Author

Closing this PR to keep everything contained in #3035 as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbt365 jamesbt365 Awaiting requested review from jamesbt365

Assignees
No one assigned
Labels
model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivinjabraham @jamesbt365