Skip to content

Commit

Permalink
👷 Upload exact versions of the packages used
Browse files Browse the repository at this point in the history
We use `^` versions for our dependencies, which means that any compatible minor
version could be pulled. However, we recently ran into an issue
(e-mission#1193 (comment))
in which a change to a minor version broke our tests. Sifting through all our
dependencies to find the ones that were bumped, and which dependencies they
bumped in turn is time consuming.

For example in the issue above, the dependency that caused the break was
`react-native`, which we don't include directly in our project.

One option to identify changes would be to check the `package-lock.json`, but
unless we are constantly reinstalling npm, we won't necessarily know what
changed around the time that the tests broke.

Uploading the `package-lock.json` from runs allows us to see the versions from
before and after the break and narrow down the potential changes.
  • Loading branch information
shankari committed Dec 21, 2024
1 parent 242cf3b commit 2c975b8
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/code-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ jobs:
source setup/activate_serve.sh
npm run test
- name: Upload exact version(s) of packages used
uses: actions/upload-artifact@v4
with:
name: versions-results
path: |
package-lock.json
./coverage/coverage-final.json
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v4
with:
Expand Down

0 comments on commit 2c975b8

Please sign in to comment.