Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.12] CVE-2023-49569 go-git: Maliciously crafted Git server replies can lead to path traversal and RCE on go-git clients #1544

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

sayan-biswas
Copy link

Changes

Update go-git dependency to mitigate the following security issue.
GHSA-449p-3h89-pw88

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Updates github.com/go-git/go-git/v5 to address CVE-2023-49569

adambkaplan and others added 2 commits March 18, 2024 09:36
Update our CI-oriented GitHub actions to run when commits merge in a
`release-v*` branch, or a pull request is opened against a `release-v*`
branch. With this change, future release branches will automatically
have CI checks enabled. This commit should be backported to enable CI
in a prior release branch.

This implements a portion of SHIP-0038.

Signed-off-by: Adam Kaplan <[email protected]>
…d to path traversal and RCE on go-git clients

Update go-git dependency to mitigate the following security issue.
GHSA-449p-3h89-pw88
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Mar 18, 2024
@openshift-ci openshift-ci bot requested review from HeavyWombat and otaviof March 18, 2024 16:45
@sayan-biswas
Copy link
Author

/kind dependency-change

@openshift-ci openshift-ci bot added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Mar 18, 2024
@sayan-biswas
Copy link
Author

/cc @adambkaplan

@openshift-ci openshift-ci bot requested a review from adambkaplan March 18, 2024 16:53
@adambkaplan
Copy link
Member

/hold

Will want #1543 to merge first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Fix looks good.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024
Copy link
Contributor

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024
@adambkaplan
Copy link
Member

Verify check failure can be ignored - issue was noted in #15433.

@qu1queee
Copy link
Contributor

The Verify failure needs to be checked. I think the golangci-lint gets updated very often, and sometimes the latest version comes with new validations that trigger new errors/warnings. My recommendation is to download the golangci-lint latest version locally, and run it against your branch, then you should see the same errors/warnings, so you can fix them as part of this same pr.

@sayan-biswas
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

@sayan-biswas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Member

/hold cancel

Verify check passes with #1547 on this branch.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2024
@adambkaplan
Copy link
Member

Red-button merging this - future PRs against release-v0.12 will pass.

@adambkaplan adambkaplan merged commit 95a10fd into shipwright-io:release-v0.12 Mar 19, 2024
11 of 13 checks passed
@adambkaplan adambkaplan linked an issue Mar 19, 2024 that may be closed by this pull request
1 task
@SaschaSchwarze0 SaschaSchwarze0 changed the title CVE-2023-49569 go-git: Maliciously crafted Git server replies can lead to path traversal and RCE on go-git clients [release-v0.12] CVE-2023-49569 go-git: Maliciously crafted Git server replies can lead to path traversal and RCE on go-git clients Mar 25, 2024
@sayan-biswas sayan-biswas deleted the cve-2023-49569 branch December 28, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] v0.12.0 impacted by CVE-2023-49569
3 participants