[16.0] shopinvader_api_sale_loyalty: do not update rewards when reading a sale

[sebastienbeau]

After reading the issue and the #1538 and the PR #1543

I do not think it's necessary to update the reward everytime we call the information on sale object. The method is already call when updating the cart : https://github.com/shopinvader/odoo-shopinvader/blob/16.0/shopinvader_api_sale_loyalty/routers/cart.py#L203

I just do that PR to show that the test are still working even if we remove it.

[sebastienbeau]

After playing with the "sale_loyalty", I pretty sure we can simply remove the method.

If a "malicious" customer try to use several time the same loyalty program (like passing several cart with a reward that consume point), the action_confirm of the sale order will block the validation, so their is no way to abuse.

[sebastienbeau]

/ocabot merge minor

[shopinvader-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1552-by-sebastienbeau-bump-minor, awaiting test results.

[shopinvader-git-bot]

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1552-by-sebastienbeau-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.