Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.59: With --use-tray-icon, main window minimizes to tray when unmapped #6117

Closed
2 tasks done
sur5r opened this issue Sep 15, 2022 · 8 comments
Closed
2 tasks done

5.59: With --use-tray-icon, main window minimizes to tray when unmapped #6117

sur5r opened this issue Sep 15, 2022 · 8 comments
Labels

Comments

@sur5r
Copy link

sur5r commented Sep 15, 2022

  • I have searched open and closed issues for duplicates
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Bug Description

Since 5.59, when starting signal with --use-tray-icon, the main window hides itself despite not receiving a close event.

I have another instance still at 5.58 which does not show this problem. I guess this might be related to b54c6f2.

Steps to Reproduce

  1. Use i3 with a workspace in tabbed mode.
  2. Have any other window open on that workspace
  3. Start signal with --use-tray-icon.
  4. Move focus to the other window

Actual Result:

The signal window gets closed/hidden.

Expected Result:

The signal window stays open.

Platform Info

Signal Version: 5.59.0 production

Operating System:

Debian GNU/Linux bookworm amd64

Link to Debug Log

https://debuglogs.org/desktop/5.59.0/a8b4784118dad7dd004dc94a1a32a2429f99e69f9ffbfef2b38cd3f898bb3c68.gz

@scottnonnenberg-signal
Copy link
Contributor

I looked at all the 'before-quit' and 'close event' lines in your log, and most of the time these events showed up when you were explicitly trying to quit. But based on what you describe, it seems like this most recent close event was generated via i3? It sends a close event when you switch focus in tabbed mode?

INFO  2022-09-15T09:57:54.544Z close event {"readyForShutdown":false,"shouldQuit":false}
INFO  2022-09-15T09:57:54.545Z System tray service: rendering the tray
INFO  2022-09-15T09:57:54.554Z close: not showing tray notice
INFO  2022-09-15T09:57:57.429Z System tray service: showing the window from the context menu
INFO  2022-09-15T09:57:57.434Z System tray service: rendering the tray

You can make it really clear in your log by shutting down, then starting up and going through the scenario (doing pretty much nothing else) and then submitting a debug log. Then we can be really clear about what events in the log correspond to which actions from you.

@sur5r
Copy link
Author

sur5r commented Sep 15, 2022

I created the debug log from a fresh session.

I will do another, slower run and note the timestamps when I switched focus, etc. Will do the same with 5.58 as well to compare this.

I will also generate a debug log from i3.

@cca88
Copy link

cca88 commented Sep 15, 2022

I am observing the same problem here: running stock Debian 11 with Xfce4. When I hide the window in 5.58.0 but do not quit the app, then signal-desktop used to be visible in (1) the tray, (2) the list of open windows (showing upon alt-tab), and (3) in the panel area of hidden windows. Now in 5.59.0 it is gone from the alt-tab window list and from the panel area. The tray icon stays.
I do not like that behavior since I cannot open the app by clicking the tray icon once (menu appears instead); this is why I had the tray icon and the icon in the panel area before. Can you restore the prior behavior?

Running like this:
Exec=signal-desktop --use-tray-icon --no-sandbox --disable-gpu

@konomikitten
Copy link

I'm having the same problem, system information:

OS: Debian GNU/Linux bookworm/sid x86_64
Kernel: 5.19.0-1-amd64
DE: Xfce 4.16

@hondogitsune
Copy link

hondogitsune commented Sep 16, 2022

@scottnonnenberg-signal
I experience a similar issue on Windows. Before the update it would minimize to taskbar and close to tray. Now it always minimizes and closes to tray, defeating the purpose of keeping the window easily clickable from taskbar. It also un-maximizes my window each time.
grafik
grafik

By no means I want to hijack a thread by and for *NIX users, but there is a cross operating system issue.
I run signal with: Signal.exe --start-in-tray --disable-smooth-scrolling

Edit:
As confirmed here:
#6119
#6120

@philpagel
Copy link

philpagel commented Sep 21, 2022

Same problem here. However, it seems that the window survives the first switch to another window but gets closed/sent to tray when I do it for the second time.

  • Debian 11
  • 5.10.0-18-amd64 1 SMP Debian 5.10.140-1 (2022-09-02)
  • i3 4.19.1-1
  • signal-desktop 5.59.0
  • call: signal-desktop --no-sandbox --start-in-tray
  • Did not happen before the last update to signal-desktop
  • Do not see anything similar with any other application so it's probably not a problem with i3 in general.

@hondogitsune
Copy link

hondogitsune commented Sep 21, 2022

grafik

Works again on Windows (for me) after the update right now. Good luck to the *NIX chums and happy recompiling/updating.
Thank you Signal devs!

@indutny-signal
Copy link
Contributor

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

7 participants