Prevent warning logs when recording-method is pcap #1889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier.
sipwise-jenkins
pushed a commit
that referenced
this pull request
Dec 20, 2024
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier. Closes #1889 Change-Id: Ifeb3038f9a5c0bd6a9b7dd92842dd61783b40263 (cherry picked from commit 759fd72)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Dec 20, 2024
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier. Closes #1889 Change-Id: Ifeb3038f9a5c0bd6a9b7dd92842dd61783b40263 (cherry picked from commit 759fd72)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Dec 20, 2024
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier. Closes #1889 Change-Id: Ifeb3038f9a5c0bd6a9b7dd92842dd61783b40263 (cherry picked from commit 759fd72)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Dec 20, 2024
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier. Closes #1889 Change-Id: Ifeb3038f9a5c0bd6a9b7dd92842dd61783b40263 (cherry picked from commit 759fd72) (cherry picked from commit 5f54fb8)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Dec 20, 2024
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as: [core] Failed to open recording metadata file '(null)' for writing: Bad address Prevent them by returning earlier. Closes #1889 Change-Id: Ifeb3038f9a5c0bd6a9b7dd92842dd61783b40263 (cherry picked from commit 759fd72) (cherry picked from commit b22903b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If recording-method is pcap, then proc is zero-initialized, so meta_filepath is empty. This shows many logs such as:
Prevent them by returning earlier.