-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify document search parameter as HTTP params #722
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good. I agree that "at" and date formats other than "yyyy-MM-dd" could be removed to simplifiy. It should be the role of the caller to do those things with "before" and "after". |
@jendib thanks, I've updated the code accordingly |
@archiloque Is this ready to merge? |
@jendib yes, I've done some integration tests and it seems to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation for #720 , feedbacks are welcome.
I'm still doing some tests.
Notes so far:
docs-web/src/main/java/com/sismics/docs/rest/util/DocumentSearchCriteriaUtil.java
to avoid making a mess ofdocs-web/src/main/java/com/sismics/docs/rest/resource/DocumentResource.java
, at the end it's not too much new code.docs-web/src/main/java/com/sismics/docs/rest/util/TagUtil.java
fromdocs-core
because it was not used outside ofdocs-web
.get
andlist
for documents when generating the responses, as a consequence I added thefile_id
field to theget
response because it was missing there but was in thelist
one, which did not make sense.I wonder if all the cases exposed through the "textual API" make sense for a programmatic one, for example:
at
can be replaced bybefore
and anafter
, should it be available?yyyy-MM-dd
one should be enough?What's your opinion ?