(chore) Config migration flow #528
Open
+77
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvx76
approved these changes
Jan 7, 2025
Comment on lines
+161
to
+165
| except AuthorizationFailedError as exc: | ||
| raise ConfigEntryAuthFailed("Log in failed for %s: %s", DOMAIN, exc) | ||
| except Exception as exc: | ||
| _LOGGER.exception("Login with %s failed: %s", DOMAIN, exc) | ||
| return False |
There was a problem hiding this comment.
question: what's the difference in behavior (by HA) when this returns False vs when an exception is raised? False ignores the migration and let's the init complete and an exception causes the init to fail?
There was a problem hiding this comment.
False means the migration did not succeed, but lets the integration complete setup. When raising ConfigEntryAuthFailed, HA signals that there is a problem with authentication, and either starts a ConfigFlow of type reauth, which we dont have yet, so it falls back to an error in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 things:
unique_idto config entries: The config entries we created, which are used at integration setup, did not have a unique identifier. This is now added, and set to the user ID generated for your MySkoda account. Unique ID's are used within HA widely, but in this case it is particularly useful to support reauthentication (if you changed your password)This is a partial reimplementation of #502, as that PR made too many changes at once and a preparation for #496 and #497