[UX] warning before launching jobs/serve when using a reauth required credentials #4479
+82
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2024 12:12
weih1121
changed the title
| @@ -536,6 +536,10 @@ def get_credential_file_mounts(self) -> Dict[str, str]: | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def can_credential_expire(self) -> bool: | |||
There was a problem hiding this comment.
nit:
Suggested change
| def can_credential_expire(self) -> bool: | |
| def can_credentials_expire(self) -> bool: |
There was a problem hiding this comment.
Checks the active credential(only one), the original make sense I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue link: #4433
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh