Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add newer examples for AI tutorial and distributed training #4509

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

Closes #4468.

Tested:

  • Rendered locally
  • Ran examples

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the doc @romilbhardwaj! LGTM.

@@ -55,6 +56,7 @@ In the above,

ulimit -n 65535

You can find more `distributed training examples <https://github.com/skypilot-org/skypilot/tree/master/examples/distributed-pytorch>`_ in our `GitHub repository <https://github.com/skypilot-org/skypilot/tree/master/examples>`_.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mention the keyword rdvz in this sentence as well so that people can easier finding it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah good point, added now.

@romilbhardwaj romilbhardwaj enabled auto-merge (squash) December 30, 2024 22:42
@romilbhardwaj romilbhardwaj merged commit 3715be2 into master Dec 30, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the docs_update_disttraining branch December 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Update docs with latest distributed training examples
2 participants