Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s] Fix L40 detection for nvidia GFD labels #4511

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

@romilbhardwaj romilbhardwaj commented Dec 26, 2024

Changes Nvidia GFD label formatter to use boundary matching instead of substring matching to handle L40 vs L4 detection.

Closes #4404.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @romilbhardwaj!

@romilbhardwaj romilbhardwaj merged commit 7c33403 into master Dec 30, 2024
19 checks passed
@romilbhardwaj romilbhardwaj deleted the k8s_fix_gpu_detection branch December 30, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] L40 GPUs get detected as L4s
2 participants