Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it includes the raw pointer
*mut openmpt_sys::openmpt_module
,Module
is not automaticallySend
. However, as far as I can tell, it's valid for it to implementSend
. According to the C API docs:So it's safe to send OpenMPT pointers to different threads, as long as access is guarded, e.g. with a mutex. So
Sync
wouldn't be good, butSend
is just fine, and will allowModule
to be wrapped in a mutex.