Switched to RxNorm db for rxnconso #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
commented
Aug 1, 2024
Comment on lines
+10
to
+26
| # [sql_config] | ||
| # file_names = [ | ||
| # "define_dx.sql", | ||
| # "define_dx_sepsis.sql", | ||
| # "define_dx_sud.sql", | ||
| # "define_lab.sql", | ||
| # "define_rx.sql", | ||
| # "define_rx_buprenorphine.sql", | ||
| # "define_rx_naloxone.sql", | ||
| # "define_rx_opioid.sql", | ||
| # "table_study_period.sql", | ||
| # "table_dx.sql", | ||
| # "table_dx_sepsis.sql", | ||
| # "table_lab.sql", | ||
| # "table_rx.sql", | ||
| # "version.sql" | ||
| # ] |
There was a problem hiding this comment.
i've been doing this manually each time im working and then undoing it on commit - since we now remember that the opioid study is not working in library v2.3, im inclined to leave it commented until we migrate these tables
dogversioning
force-pushed
the
mg/rxnorm-join
branch
from
1f4dd1b to
f1ea960
Compare
mikix
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
lol OK the one-by-one approach worked, it seems 😄
There was a problem hiding this comment.
on the one hand: this feels incredibly wrong
on the other hand: it's 60x faster than the 'smart' way, so 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
rxnormdatabase directly rather than the static filen.b. after this goes in, i'm going to rebase together the last few commits to get the large files out of project history.