Excluded rules summary #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a series of tables designed to help debug study configs by providing a list of rules that were excluded, but were considered potential candidates for exclusion. This adds a new study arg, debug, which is used to enable these tables. They are off by default.
mikix
approved these changes
Aug 5, 2024
Comment on lines
+3
to
+9
| rxcui1, | ||
| tty1, | ||
| rel, | ||
| rela, | ||
| rxcui2, | ||
| tty2, | ||
| str2 |
There was a problem hiding this comment.
Just as an aside, these field names are all meaningless to someone not steeped in this repo. I know some of this is inherited. But phew.
There was a problem hiding this comment.
i :hate: these names. but it's either exactly an NIH label, or an NIH label with a number, so it makes it easier to look up in their documentation.
it's certainly an artifact of a bygone age.
dogversioning
force-pushed
the
mg/excluded_rules
branch
from
1df39f4 to
b0ba59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a series of tables designed to help debug study configs by providing a list of rules that were excluded, but were considered potential candidates for exclusion.
This adds a new study arg, debug, which is used to enable these tables. They are off by default.