Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana TODOs #15726

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

Solana TODOs #15726

wants to merge 18 commits into from

Conversation

yashnevatia
Copy link

@yashnevatia yashnevatia commented Dec 17, 2024

To run integration tests:

nix develop .
# from root
docker run --name test-db-core -p 5432:5432 -e POSTGRES_PASSWORD=postgres -d postgres
# from root
./core/scripts/setup_testdb.sh
cd ./deployment/ccip/changeset
go test -run TestDeployChainContractsChangeset -v

@yashnevatia yashnevatia requested review from a team as code owners December 17, 2024 09:33
@yashnevatia yashnevatia marked this pull request as draft December 17, 2024 09:33
@yashnevatia yashnevatia requested a review from tt-cll December 17, 2024 09:33
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and b7429a9 (yn-solana).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestInitialAddChainAppliedTwice 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3m37.176666666s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

github-actions bot commented Dec 17, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , Flakeguard Root Project / Get Tests To Run , GolangCI Lint (core/scripts) , GolangCI Lint (.) , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , Flakeguard Deployment Project / Get Tests To Run , Flakeguard Root Project / Run Tests , Flakeguard Root Project / Report , Flakeguard Deployment Project / Run Tests , Flakeguard Deployment Project / Report , lint , SonarQube Scan , Flakey Test Detection

1. Missing go.sum entry for module providing package golang.org/x/exp/maps:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/ethereum/go-ethereum@v1.14.11/p2p/netutil/net.go:29:2: missing go.sum entry for module providing package golang.org/x/exp/maps (imported by github.com/smartcontractkit/chainlink/v2/core/web); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/web@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
**Why**: The Go module `golang.org/x/exp/maps` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

2. Missing go.sum entry for module providing package golang.org/x/net/proxy:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/gorilla/websocket@v1.5.1/client.go:23:2: missing go.sum entry for module providing package golang.org/x/net/proxy (imported by github.com/gorilla/websocket); to add:
	go get github.com/gorilla/websocket@v1.5.1
**Why**: The Go module `golang.org/x/net/proxy` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

3. Missing go.sum entry for module providing package golang.org/x/exp/constraints:[Run Tests]

Source of Error:
../chains/evm/assets/units.go:6:2: missing go.sum entry for module providing package golang.org/x/exp/constraints (imported by github.com/smartcontractkit/chainlink/v2/core/chains/evm/assets); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/chains/evm/assets@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
**Why**: The Go module `golang.org/x/exp/constraints` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

4. Missing go.sum entry for module providing package golang.org/x/exp/rand:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/cockroachdb/pebble@v1.1.2/internal/batchskl/skl.go:67:2: missing go.sum entry for module providing package golang.org/x/exp/rand (imported by github.com/cockroachdb/pebble/internal/batchskl); to add:
	go get github.com/cockroachdb/pebble/internal/batchskl@v1.1.2
**Why**: The Go module `golang.org/x/exp/rand` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

5. Missing go.sum entry for module providing package github.com/stretchr/testify/assert:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/utils/tests/tests.go:8:2: missing go.sum entry for module providing package github.com/stretchr/testify/assert (imported by github.com/smartcontractkit/chainlink/core/scripts/common); to add:
	go get -t github.com/smartcontractkit/chainlink/core/scripts/common
**Why**: The Go module `github.com/stretchr/testify/assert` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

6. Missing go.sum entry for module providing package github.com/stretchr/testify/require:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/utils/tests/tests.go:9:2: missing go.sum entry for module providing package github.com/stretchr/testify/require (imported by github.com/smartcontractkit/chainlink/v2/core/web); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/web@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
**Why**: The Go module `github.com/stretchr/testify/require` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

7. Missing go.sum entry for module providing package golang.org/x/net/html:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/gabriel-vasile/mimetype@v1.4.3/internal/charset/charset.go:9:2: missing go.sum entry for module providing package golang.org/x/net/html (imported by github.com/gabriel-vasile/mimetype/internal/charset); to add:
	go get github.com/gabriel-vasile/mimetype/internal/charset@v1.4.3
**Why**: The Go module `golang.org/x/net/html` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

8. Missing go.sum entry for module providing package golang.org/x/net/http2:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.10.0/gin.go:20:2: missing go.sum entry for module providing package golang.org/x/net/http2 (imported by k8s.io/client-go/rest); to add:
	go get k8s.io/client-go/rest@v0.31.1
**Why**: The Go module `golang.org/x/net/http2` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

9. Missing go.sum entry for module providing package golang.org/x/net/http2/h2c:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/gin-gonic/gin@v1.10.0/gin.go:21:2: missing go.sum entry for module providing package golang.org/x/net/http2/h2c (imported by github.com/gin-gonic/gin); to add:
	go get github.com/gin-gonic/gin@v1.10.0
**Why**: The Go module `golang.org/x/net/http2/h2c` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

10. Missing go.sum entry for module providing package github.com/stretchr/testify/mock:[Run Tests]

Source of Error:
../logger/logger_mocks.go:6:2: missing go.sum entry for module providing package github.com/stretchr/testify/mock (imported by github.com/smartcontractkit/chainlink/v2/core/logger); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/logger@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
**Why**: The Go module `github.com/stretchr/testify/mock` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

11. Missing go.sum entry for module providing package golang.org/x/tools/go/ast/astutil:[Run Tests]

Source of Error:
../gethwrappers/abigen.go:18:2: missing go.sum entry for module providing package golang.org/x/tools/go/ast/astutil (imported by github.com/smartcontractkit/ccip-owner-contracts/pkg/gethwrappers); to add:
	go get github.com/smartcontractkit/ccip-owner-contracts/pkg/gethwrappers@v0.0.0-salt-fix
**Why**: The Go module `golang.org/x/tools/go/ast/astutil` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

12. Missing go.sum entry for module providing package golang.org/x/net/trace:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/google.golang.org/grpc@v1.67.1/trace_withtrace.go:26:2: missing go.sum entry for module providing package golang.org/x/net/trace (imported by google.golang.org/grpc); to add:
	go get google.golang.org/grpc@v1.67.1
**Why**: The Go module `golang.org/x/net/trace` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

13. Missing go.sum entry for module providing package golang.org/x/net/http2/hpack:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/google.golang.org/grpc@v1.67.1/internal/transport/controlbuf.go:32:2: missing go.sum entry for module providing package golang.org/x/net/http2/hpack (imported by google.golang.org/grpc/internal/transport); to add:
	go get google.golang.org/grpc/internal/transport@v1.67.1
**Why**: The Go module `golang.org/x/net/http2/hpack` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

14. Missing go.sum entry for module providing package golang.org/x/exp/slices:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/smartcontractkit/chainlink-common@v0.4.1-0.20241223143929-db7919d60550/pkg/loop/logger.go:14:2: missing go.sum entry for module providing package golang.org/x/exp/slices (imported by github.com/cosmos/cosmos-sdk/types); to add:
	go get github.com/cosmos/cosmos-sdk/types@v0.47.11
**Why**: The Go module `golang.org/x/exp/slices` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

15. Missing go.sum entry for module providing package github.com/decred/dcrd/dcrec/secp256k1/v4:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/btcsuite/btcd/btcec/v2@v2.3.2/btcec.go:23:2: missing go.sum entry for module providing package github.com/decred/dcrd/dcrec/secp256k1/v4 (imported by github.com/btcsuite/btcd/btcec/v2); to add:
	go get github.com/btcsuite/btcd/btcec/v2@v2.3.4
**Why**: The Go module `github.com/decred/dcrd/dcrec/secp256k1/v4` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

16. Missing go.sum entry for module providing package github.com/decred/dcrd/dcrec/secp256k1/v4/ecdsa:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/btcsuite/btcd/btcec/v2@v2.3.2/ecdsa/error.go:7:2: missing go.sum entry for module providing package github.com/decred/dcrd/dcrec/secp256k1/v4/ecdsa (imported by github.com/btcsuite/btcd/btcec/v2/ecdsa); to add:
	go get github.com/btcsuite/btcd/btcec/v2/ecdsa@v2.3.4
**Why**: The Go module `github.com/decred/dcrd/dcrec/secp256k1/v4/ecdsa` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

17. Missing go.sum entry for module providing package golang.org/x/net/context:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.37.5/abci/types/application.go:4:2: missing go.sum entry for module providing package golang.org/x/net/context (imported by github.com/cometbft/cometbft/abci/types); to add:
	go get github.com/cometbft/cometbft/abci/types@v0.37.5
**Why**: The Go module `golang.org/x/net/context` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

18. Missing go.sum entry for module providing package golang.org/x/net/netutil:[Run Tests]

Source of Error:
/home/runner/go/pkg/mod/github.com/cometbft/cometbft@v0.37.5/p2p/transport.go:9:2: missing go.sum entry for module providing package golang.org/x/net/netutil (imported by github.com/cometbft/cometbft/p2p); to add:
	go get github.com/cometbft/cometbft/p2p@v0.37.5
**Why**: The Go module `golang.org/x/net/netutil` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

19. Missing go.sum entry for module providing package github.com/gagliardetto/solana-go:[Run Tests]

Source of Error:
../services/keystore/keys/solkey/key.go:10:2: missing go.sum entry for module providing package github.com/gagliardetto/solana-go (imported by github.com/smartcontractkit/chainlink/v2/core/cmd); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/cmd@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
**Why**: The Go module `github.com/gagliardetto/solana-go` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

20. Missing go.sum entry for module providing package golang.org/x/mod/semver:[Run Tests]

Source of Error:
../services/gateway/handlers/functions/allowlist/allowlist.go:16:2: missing go.sum entry for module providing package golang.org/x/mod/semver (imported by github.com/smartcontractkit/chainlink/v2/core/services/gateway/handlers/functions/allowlist); to add:
	go get github.com/smartcontractkit/chainlink/v2/core/services/gateway/handlers/functions/allowlist@v2.14.0-mercury-20240807.0.20241106193309-5560cd76211a
**Why**: The Go module `golang.org/x/mod/semver` is missing from the `go.sum` file, which is required for dependency verification. **Suggested fix**: Run `go mod tidy` to update the `go.sum` file with the missing module entries.

21. Missing go.sum entry for module providing package

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 42ed1da (yn-solana).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestInitialAddChainAppliedTwice 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/deployment/ccip/changeset false 3m35.683333333s @smartcontractkit/ccip, @smartcontractkit/core, @smartcontractkit/deployment-automation

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants