-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCIP-4687 Support Solana in the FeeQuoter #15811
base: develop
Are you sure you want to change the base?
Conversation
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
Static analysis results are availableHey @jhweintraub, you can view Slither reports in the job summary here or download them as artifact here. |
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Scheduled Run Frequency , Detect Changes , Flakeguard Root Project / Get Tests To Run , Flakeguard Deployment Project , test-scripts , GolangCI Lint (.) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , Flakeguard Root Project / Run Tests , lint , Flakeguard Root Project / Report , SonarQube Scan , Flakey Test Detection 1. Max code size exceeded:[go_core_ccip_deployment_tests]Source of Error:
Why: The error "max code size exceeded" indicates that the size of the contract being deployed exceeds the maximum allowed size for a smart contract on the blockchain. This is a common issue when the contract code is too large to be deployed in a single transaction. Suggested fix: To resolve this issue, consider breaking down the contract into smaller, modular contracts that can be deployed separately. Alternatively, optimize the contract code to reduce its size by removing unnecessary functions or using libraries that minimize code size. 2. Max code size exceeded:[go_core_tests]Source of Error:
Why: Similar to the previous error, this indicates that the contract being tested for deployment exceeds the maximum allowed size for a smart contract on the blockchain. Suggested fix: Apply the same strategies as mentioned above: break down the contract into smaller parts or optimize the code to reduce its size. Additionally, ensure that the test environment is configured to handle the deployment of smaller, modular contracts. |
Quality Gate passedIssues Measures |
Add Solana Support to the FeeQuoter by adding
CHAIN_FAMILY_SELECTOR_SOL
SOL_EXTRA_EXTRA_ARGS_V1_TAG