Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShapeId as detail in completions #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jan 4, 2025

It can be useful when a given name shows up in many namespaces and you want to choose which one gets imported.

image

@kubukoz kubukoz requested a review from a team as a code owner January 4, 2025 00:08
@kubukoz kubukoz requested a review from haydenbaker January 4, 2025 00:08
@kubukoz
Copy link
Contributor Author

kubukoz commented Jan 4, 2025

I should've remembered about #166 first... but given this is a one-liner (plus tests), perhaps we can have this without waiting for the other PR? (which is massive, in a good way :) )

Copy link
Contributor

@yasmewad yasmewad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants