UPDATE for RFC30: Serialization and deserialization #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/thomas-k-cameron/smithy-rs into serialization_and_deserialization
pre-commit
Section is deleted in response to the discussion smithy-lang#1944 (comment)
LukeMathWalker
approved these changes
Jan 9, 2023
|
Thank you for approving @LukeMathWalker ! |
Velfi
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
@LukeMathWalker has raised concern over the feature-gate that it may become confusing in the future.
#2183 (comment)
I thought that he's concern makes sense and decided to create a PR to discuss if it is necessary to update the RFC.
I'm going to mention people who was involved in the discussion of RFC30.
@rcoh @Velfi @ysaito1001 @jdisanti
Description
prefix the feature-gate with
serde.serializewill becomeserde-serializedeserializewill becomeserde-deserializeTesting
NA
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.