-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New debug log approach and fix logging setup #168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - Looks good!
I think for adding info/error - it probably makes sense to do so either in the initialize middleware (ie, very last) or completly outside of middleware in the client operation method, right before the error is raised. If error, log error. else, log info of the invocation.
But agree those can be added later.
This reverts commit 78367d1.
…date interceptors logging
Log level should be removed - it was previously for configuring the level that the SDK spits out.
Logger defaults to null.
Add better debug logging to middleware and a module to handle it.
I did not add error/info logging for the entire request - thoughts? This can be added later.
Example logging: