Refactor polish and weld #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Dec 18, 2024
alextwoods
approved these changes
Dec 18, 2024
Comment on lines
+13
to
+19
| Welds.load!(self) | ||
| @welds = Welds.for(model) | ||
| Polishes.load!(self) | ||
| @polishes = Polishes.for(model) | ||
|
|
||
| @welds.each { |weld| weld.preprocess(model) } | ||
| @model = Vise::Model.new(model) |
|
|
||
| module Smithy | ||
| # @api private | ||
| module Polishes |
There was a problem hiding this comment.
Naming discussion. Polishes reads a little weirdly to me - it almost feels like this should be Polishers. Ie, a Polisher can take the polish action, eg: @polishers.each { |p| p.polish }.
There was a problem hiding this comment.
Polishes is the plural of polish. We can think about changing this.
| def smith(plan) | ||
| artifact = Smithy::Forge.forge(plan) | ||
| Smithy::Polish.descendants.each { |p| p.new(plan).polish(artifact) } | ||
| plan.polishes.each { |polish| polish.polish(artifact) } |
There was a problem hiding this comment.
I'm struggling a little bit with why we have separate Welds and Polishes. Why are these separate extension points - couldn't "polish" just be a hook on a weld?
There was a problem hiding this comment.
Polish required instances because it uses Thor actions. Weld now has instances but doesn't include thor. I'm not sure if we should keep the distinction anymore or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls model out of plan, so that polish and welding can accept plan, and at various steps, would not have incomplete models or mismatched types.