Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize module names #243

Open
wants to merge 4 commits into
base: decaf
Choose a base branch
from
Open

Normalize module names #243

wants to merge 4 commits into from

Conversation

mullermp
Copy link
Contributor

@mullermp mullermp commented Jan 8, 2025

We are not allowed to have fun anymore.

end

# helper classes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: extra line?

Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I like the Anvil -> Views + flattening and I think model makes more sense than vice.

In terms of other names:

I think polish is pretty clear on what it does - though I'm also not 100% convinced it should be separate functionality from Welds (ie, why not just have a polish or post_process hook on weld.

For Weld - Naming for this sort of functionality is hard. "Plugin" is already very overloaded. I think an alternative would be "Integration" or "Extension" or something like that, but its also not necessarily more descriptive than "Weld". "Weld" also feels some what similar to "Railtie", so I think its reasonable to keep it.

Copy link
Contributor

@jterapin jterapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good 👍

@@ -3,16 +3,16 @@
require 'rails/railtie'
require 'thor'

require_relative 'smithy/tools'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't mind that utils are called tools. I felt it was pretty straightforward there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants