feat: add log for failed refresh of retry token #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
approved these changes
May 15, 2024
jbelkins
reviewed
May 15, 2024
| @@ -61,18 +61,18 @@ public struct RetryMiddleware<Strategy: RetryStrategy, | |||
| do { | |||
| try await strategy.refreshRetryTokenForRetry(tokenToRenew: token, errorInfo: errorInfo) | |||
| } catch { | |||
| // TODO: log token error here | |||
| context.getLogger()?.error("Failed to refresh retry token: \(errorInfo)") | |||
There was a problem hiding this comment.
What does printing errorInfo actually log?
There was a problem hiding this comment.
I changed this to errorInfo.errorType which will print out the type of error based on RetryErrorType enum:
/// This is a connection level error such as a socket timeout, socket connect error, tls negotiation timeout etc...
/// Typically these should never be applied for non-idempotent, request types since in this scenario, it’s impossible
/// to know whether the operation had a side effect on the server.
case transient
/// This is an error where the server explicitly told the client to back off, such as a 429 or 503 HTTP error.
case throttling
/// This is a server error that isn’t explicitly throttling but is considered by the client to be something that should be retried.
case serverError
/// Doesn’t count against any budgets. This could be something like a 401 challenge in HTTP.
case clientError
jbelkins
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1207
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.