fix: Bump up maxConnectionsPerEndpoint on CRT HTTP client #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
reviewed
Dec 6, 2024
| @@ -97,7 +97,8 @@ public extension DefaultSDKRuntimeConfiguration { | |||
| let connectTimeoutMs = httpClientConfiguration.connectTimeout.map { UInt32($0 * 1000) } | |||
| let socketTimeout = UInt32(httpClientConfiguration.socketTimeout) | |||
| let config = CRTClientEngineConfig( | |||
| telemetry: httpClientConfiguration.telemetry ?? CRTClientEngine.noOpCrtClientEngineTelemetry, | |||
| maxConnectionsPerEndpoint: 100, | |||
There was a problem hiding this comment.
What is the default for this?
There was a problem hiding this comment.
50 -- this doubles it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test run: https://github.com/awslabs/aws-sdk-swift/actions/runs/12205746028
Issue #
Description of changes
doubles connection limit from 50 -> 100
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.