Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run repo-sync workflow only in source repo #884

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Dec 12, 2024

Issue #

1934

Description of changes

  • Adds if condition checks on repo-sync workflow and others so it only runs in source repo when triggered by commit to main / manually, or when it's triggered by pull request (regardless of public vs private repo)

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -1,8 +1,6 @@
name: Codegen

on:
push:
branches: [ main ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to remove CI from the main branch. Instead let's figure out how to have it trigger only on the public repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted change after discussion, now uses if checks instead to filter running on commit to main in private repo.

@sichanyoo sichanyoo requested a review from jbelkins December 16, 2024 17:52
@sichanyoo sichanyoo merged commit fec1b26 into main Dec 17, 2024
27 checks passed
@sichanyoo sichanyoo deleted the chore/run-repo-sync-only-in-source branch December 17, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants