Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatting instructions #99

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jackrein
Copy link

@jackrein jackrein commented Dec 8, 2024

The README did not mention the extension supports formatting of .smithy files. This change advertises the formatting feature and adds instructions for use

Tested auto formatting in VS code by adding and removing the block in settings.json and attempting to format via the command palette. Formatting worked when the block was there, and did not do anything when the block was omitted.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The README did not mention the extension supports formatting of
`.smithy` files. This change advertises the formatting feature
and adds instructions for use
@jackrein jackrein requested a review from a team as a code owner December 8, 2024 03:48
@jackrein jackrein requested a review from haydenbaker December 8, 2024 03:48
@yasmewad
Copy link

yasmewad commented Dec 9, 2024

Can you provider information on how did you test it?

Thanks!

@jackrein
Copy link
Author

jackrein commented Dec 9, 2024

Hey @yasmewad, I added my ad-hoc testing method to the description above

Tested auto formatting in VS code by adding and removing the block in settings.json and attempting to format via the command palette. Formatting worked when the block was there, and did not do anything when the block was omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants