-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Bluesky changes needed for backfeed #571
Merged
+385
−18
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2b9f2d8
Implement Bluesky changes needed for backfeed
JoelOtter a47a26e
Fix tests after rebase
JoelOtter d73051a
Remove redundant user_to_actor
JoelOtter 465c6c2
Add back TODO that was inadvertently removed
JoelOtter 54df15a
Add depth=1 to get_comment, add test
JoelOtter 48b264c
Add test for activities with likes
JoelOtter 1fb9285
add test for fetch_shares
JoelOtter 222e4d9
Add test for include_shares
JoelOtter 30c7294
Add test for replies
JoelOtter c3f58a7
Update replies test to include recursive replies
JoelOtter 4d4ba6d
Remove some redundant stuff
JoelOtter cbab12e
Drop context field
JoelOtter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have like/share support in
to_as1
, so we may want to use that eventually instead. Low priority though, definitely doesn't have to be in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah I might leave this for now just until I untangle what we need to do with actors/IDs/tags and whether that stuff ought to live in
to_as1
or out here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely! Yeah I think
to_as1
can do most of these, especially if we start using its existing did and handle kwargs for actor, but we can do that later.