-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1029631: Optimize streaming PUT memory usage #1266
Draft
sfc-gh-ext-simba-jl
wants to merge
14
commits into
master
Choose a base branch
from
SNOW-1029631-optimize-put-mem
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+167
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1029631-optimize-put-mem
branch
from
December 5, 2024 08:37
92386e2
to
9b01fd1
Compare
sfc-gh-ext-simba-jl
changed the title
SNOW-1029631: Optimize PUT memory usage
SNOW-1029631: Optimize streaming PUT memory usage
Dec 5, 2024
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1029631-optimize-put-mem
branch
from
December 5, 2024 18:58
9b01fd1
to
673e693
Compare
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1029631-optimize-put-mem
branch
from
December 11, 2024 14:44
1ecb657
to
cd542f1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
- Coverage 82.19% 82.13% -0.07%
==========================================
Files 55 55
Lines 13484 13539 +55
==========================================
+ Hits 11083 11120 +37
- Misses 2401 2419 +18 ☔ View full report in Codecov by Sentry. |
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1029631-optimize-put-mem
branch
from
December 30, 2024 19:33
6ece113
to
b98006b
Compare
…owflakedb/gosnowflake into SNOW-1029631-optimize-put-mem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimize streaming PUT memory usage.
Compared the memory usage for uploading 1GB file using
runtime.ReadMemStats
Before change: 11GB
After change: 1.5GB
Checklist