Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-899912 patching out urllib3.contrib.pyopenssl deprecation warnings #1735

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-899912: DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated #1713

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Patching out https://github.com/snowflakedb/vendored-urllib3/commit/f95b9640604e7dd70d50d81f68fd14a36c082841

@sfc-gh-mkeller sfc-gh-mkeller force-pushed the mkeller/SNOW-899912-remove_deprecation_warning branch from ba79e10 to a797ab7 Compare September 22, 2023 23:05
@sfc-gh-mkeller sfc-gh-mkeller marked this pull request as ready for review September 22, 2023 23:26
@sfc-gh-mkeller sfc-gh-mkeller merged commit ad3e295 into main Sep 25, 2023
69 of 72 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-899912-remove_deprecation_warning branch September 25, 2023 21:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-899912: DeprecationWarning: 'urllib3.contrib.pyopenssl' module is deprecated
2 participants