Upgraded to netstandard. #763
Conversation
|
Would love to see this getting into the main repo! |
| @@ -0,0 +1,54 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
There was a problem hiding this comment.
why are you adding these files with the .old extension? just delete the old stuff
There was a problem hiding this comment.
well I have performed the first conversion and asked people to check if it works well. If it will not work we will see exactly what is missing in the "old" files. The "old" files have the csproj items which were not transferred to the new csproj. As soon as the library is verified we can delete the "old" files.
There was a problem hiding this comment.
Ok, please ask someone to test it, and if it works well, remove the .old files. Then after that we can merge this PR.
|
I've already added a proper PR some month ago: #687 As we already discuss in my PR upgrade to 4.6.1 is needed to respect coding rules for netcore/netstandard (net 4.5 is not compatible). Without 4.6.1 it could break on any library upgrade or is not working as library in other projects where coding follows netstandard rules. Also BigMath and Ionic.Zlib are no netstandard compatible versions (PCL is deprecated by Microsoft for netstandard), for both are netstandard Version available - Please change them. |
|
@LORDofDOOM for bigmath I've ported to NetStandard a long time ago: and there is an Ionic.Zlib nestandard port too: |
|
I created a fork with netstandard and published it via nuget, it works in my project. |
|
@ilyalatt can you create a PullRequest please? |
No description provided.