New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add detox recipe #22

Merged

km1chno merged 32 commits into main from @maciekstosio/feat-add-detox

Aug 9, 2024

Collaborator

maciekstosio commented Jul 17, 2024 •

edited

Loading

fixes: https://github.com/orgs/software-mansion-labs/projects/12?pane=issue&itemId=70477880
resolves: https://github.com/orgs/software-mansion-labs/projects/12/views/1?pane=issue&itemId=70273961

Android workflow more or less works - emulator does's terminated - need to be investigated.

TODO:

fix android sim not terminated
make iOS analogically
consider using https://github.com/marketplace/actions/wait-for-checks instead of uses and needs
consider disabling buildDebug as separate workflow (?)
handle different managers
handle monorepo
cache with fingerprint

maciekstosio and others added 9 commits

July 5, 2024 11:04


          Start progress on detox

5d53923


          Merge branch 'main' into @maciekstosio/feat-add-detox

0b90286


          chore: move detox

9fbf36c


          working android

78b30c5


          Handle skip git check properly

b7be496


          Handle separate build and detox (now working yet)

39f9092


          Separate android and build and use cache

cb6ba38


          rename key

e15115f


          Merge branch 'main' into @maciekstosio/feat-add-detox

0d873cc

km1chno reviewed

View reviewed changes

src/commands/react-native-ci-cli.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/commands/react-native-ci-cli.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/commands/react-native-ci-cli.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/buildDebug.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/buildDebug.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/buildDebug.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/buildDebug.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/buildDebug.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/detox.ts Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/commands/react-native-ci-cli.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/detox.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/detox.ts Outdated Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/recipes/detox.ts Outdated Show resolved Hide resolved

km1chno added 6 commits

July 17, 2024 15:03


          add missing eol in templates

6f16c2c


          fix android emulator not finishing

17e15d6


          add ios detox recipe and ios release build

cbba5b5


          move skip git check flag to main file

4530df0


          Merge branch 'main' into @maciekstosio/feat-add-detox

87f8611


          rectructurize build workflows

e477047

Contributor

km1chno commented Jul 23, 2024

Something to consider: npx expo prebuild prompts the user about package name, what if we run with --silent flag?

Collaborator Author

maciekstosio commented Jul 23, 2024

But the only reason why we run npx expo prebuild is so it handles the package name case :D

km1chno added 5 commits

July 29, 2024 10:47


          Merge branch 'main' into @maciekstosio/feat-add-detox

8be1db1


          fix github head sha

295b167


          add info about github token to readme

2158fc5


          add warning about creating GH_TOKEN after completing detox recipe

3f30bec


          change test apk path

c79403b

km1chno changed the title ~~[WIP] Add detox recipe~~ feat: add detox recipe

km1chno linked an issue

that may be closed by this pull request

Add Detox recipe #7

Closed

maciekstosio commented

View reviewed changes

src/extensions/projectContext.ts Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/extensions/projectContext.ts Outdated Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/extensions/scripts.ts Outdated Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/recipes/build-release.ts Outdated Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/recipes/build-release.ts Outdated Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/recipes/detox.ts Outdated Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/recipes/detox.ts Outdated Show resolved Hide resolved

km1chno added 4 commits

August 7, 2024 14:42


          Merge branch 'main' into @maciekstosio/feat-add-detox

42ae72e


          Merge branch 'main' into @maciekstosio/feat-add-detox

834a452


          add appJson to projectConfig extension

3af97de


          change expo prebuild message

6daad41

maciekstosio commented

View reviewed changes

Collaborator Author

maciekstosio left a comment

Minor improvements and then I think you're good to go. I can't approve as I'm the author 😅

src/recipes/detox.ts Outdated Show resolved Hide resolved

src/recipes/detox.ts Outdated Show resolved Hide resolved

km1chno added 3 commits

August 8, 2024 11:24


          add skipInstalledCheck flag to dependencies.add

3d83c0d


          fix detox and release build recipes in monorepo

123e24f


          Change detox non-expo error to not terminate the whole script

38fa2a3

km1chno reviewed

View reviewed changes

src/extensions/dependencies.ts Show resolved Hide resolved

km1chno reviewed

View reviewed changes

src/templates/detox/test-detox-android.ejf Outdated Show resolved Hide resolved

maciekstosio commented

View reviewed changes

src/extensions/dependencies.ts Outdated Show resolved Hide resolved

km1chno mentioned this pull request

Reconsider dependency extension #47

Open

km1chno added 2 commits

August 9, 2024 10:44


          change version and skipInstalledCheck params to object

16071f6


          remove redundant empty lines in workflows yamls before saving

9b640a4

km1chno merged commit f108c92 into main

3 checks passed

km1chno deleted the @maciekstosio/feat-add-detox branch

August 9, 2024 09:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet