Replaces fs-err in remove_tmp_snapshot_archives()

[brooksprumo]

Problem

The fs-err create does not include source errors when displaying the error. The solana repo's convention is to include the source error in the message, so we end up losing the underlying cause of an IO error if fs_err is used.

Here's more info about the issue that I raised on the fs-err repo: andrewhickman/fs-err#51. Turns out their behavior is desired, and likely the most idiomatically correct Rust way. But we're not going to change the solana repo's error reporting anytime soon. Instead, we should replace the use of fs-err with regular std::fs.

Related: #34799

Summary of Changes

Replace fs-err in remove_tmp_snapshot_archives()

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f9d915) 81.8% compared to head (a1c706a) 81.7%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #34839     +/-   ##
=========================================
- Coverage    81.8%    81.7%   -0.1%     
=========================================
  Files         825      825             
  Lines      223269   223269             
=========================================
- Hits       182635   182619     -16     
- Misses      40634    40650     +16     

[steviez]

LGTM and interesting note that we're not following general convention.

While the cascading sources (if there are multiple layers of error on the bubble up) can make things verbose, having that extra information is definitely valuable. And agreed on no massive overhauls in the short term