Make phpunit_v6 branch work with PHPUnit 6!

[petrkotek]

Hey @IsaacChapman,

I finally managed to get solanolabs/solano-phpunit working with PHPUnit 6!

As you can see, support for old PHPUnit 4 and 5 has been dropped as well as PHP 5.3 and 5.5 support.

Please, consider merging this into your phpunit_v6 branch so we can start using this official repository rather than our fork.

This PR will fix issue #11.

Thanks!

[IsaacChapman]

@petrkotek,

Sorry for the delay as I am taking a look at this now. My goal with the phpunit_v6 branch was to make it compatible with all current phpunit versions in use on Solano CI and merge it into the master branch. I can merge this into the solanolabs/solano-phpunit:phpunit_v6 branch if your preference is to use the phpunit_v6 of this repository, but I will have to re-add support for earlier versions of phpunit before merging your changes with master.

[petrkotek]

Make sense - Although IMHO it's worth the hassle to keep the compatibility with PHPUnit 5 since it's official support ends relatively soon (on 2/2/2018 as per https://phpunit.de/). Maybe you could just release new major version and people who need PHPUnit 5 would stick with the previous one before they upgrade to PHPUnit 6.

[petrkotek]

@IsaacChapman: do you still think it's worth the effort to keep backwards compatibility with PHPUnit 4 and 5?

[IsaacChapman]

I do still think supporting PHPUnit versions prior to 6 is still required. I was working on that compatibility on the phpunit_multi_ver_compat branch before getting sidetracked. I'll work on validating and testing those changes in real world situations in the near future.

While I won't likely merge your PR into master, I can still merge it into it into the phpunit_v6 branch if you'd like.

[petrkotek]

Merging into phpunit_v6 would be actually useful as i could get rid of my fork. Cheers!

[rayward]

@IsaacChapman is this something we can move ahead with still?

[rayward]

I do still think supporting PHPUnit versions prior to 6 is still required.

Version 6 has been out for quite some time now, is it worth keeping support for such old versions? This repo isn't getting actively developed, so perhaps the PHPUnit v6 changes can be merged to master and tagged at 1.0. Users wanting support for older versions can use a 0.x release.