Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InSpec tests do not run on pull requests #25

Open
simonwgill opened this issue Jan 1, 2019 · 3 comments
Open

InSpec tests do not run on pull requests #25

simonwgill opened this issue Jan 1, 2019 · 3 comments
Labels
hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Help Wanted Assistance is required to resolve this issue Priority: High Critical work that must be completed Tech Debt Will improve the maintainability of the codebase

Comments

@simonwgill
Copy link
Contributor

Cookbook version

4.0.1

Chef-client version

15.0.109

Platform Details

CircleCI 2.1

Scenario:

When I PRed my previous tiny change, it seemed odd that the check succeeded when I knew that the cookbook failed on many operating systems (issues to come).

Steps to Reproduce:

  1. Create a pull request to the sous-chef/snort repository

Expected Result:

I would expect that inspec tests would be run in CircleCI and the results would be available to the maintainers.

Actual Result:

linting and Dangerfile checks do occur. The kitchen converge and verify tasks do not.

@damacus
Copy link
Member

damacus commented Jan 1, 2019

Hey,

would you like to submit a PR for this one? Examples can be found in the following repositories. If you need any guidance don't hesitate to ask, or stop by the Sous Chefs channel on the Chef Community Slack

https://github.com/sous-chefs/postgresql
https://github.com/sous-chefs/haproxy

@xorima xorima added Help Wanted Assistance is required to resolve this issue Priority: High Critical work that must be completed Tech Debt Will improve the maintainability of the codebase labels May 11, 2019
@simonwgill
Copy link
Contributor Author

I've caught up with the 2.0 orb and Xorima's circleci2.0 branch. I'm still finding the single flow of dokken to be a problem, so I'd rather stick with dokken-single for the moment.

Have somehow managed to close my pull request while faffing though, I'll get a new one done later for this stage.

@github-actions
Copy link

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

@github-actions github-actions bot added the Stale label Sep 30, 2020
@xorimabot xorimabot removed the Stale label Sep 30, 2020
@ramereth ramereth added the hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest An issue highlighted for the digital ocean Hacktoberfest Event Help Wanted Assistance is required to resolve this issue Priority: High Critical work that must be completed Tech Debt Will improve the maintainability of the codebase
Projects
None yet
Development

No branches or pull requests

6 participants