-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables testing with kitchen-dokken for some of the supported OSes. #26
Conversation
.kitchen.yml
Outdated
- name: centos-7 | ||
- name: redhat-7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
centos-7 should/does cover redhat-7. We don't tend to test using this as it isn't available as a dokken or Vagrant image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shooooould, but I've had some issues with my testing on the EC2 provider with package inconsistencies between variants. RHEL-7 fails to install libdnet and libdnet-devel, where CentOS 7 is perfectly happy.
I take the point about Vagrant though, I haven't been checking that it would work since I broke my work desktop with too many kitchen instances running at once.
.circleci/config.yml
Outdated
platform: fedora-27 | ||
requires: [ danger, lint ] | ||
- kitchen/dokken-single: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kitchen/dokken covers most of these platforms for less yaml :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but it also includes centos-6, which will break the check. I don't know if there's a way to have a loop in this yaml - so platform: [ centos-7, fedora-27, ubuntu-1804 ] and didn't want to burn too many cycles on that at this point.
Also this way there's also a number of dokken jobs which can be parallelized and reported separately. Minor thing, but I've found it helpful.
This is an awesome start. For reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some updating to use the right platforms and the new orb.
See: #31 |
I'll catch up with the changes over the next couple of weeks and see what I can do.
…________________________________
From: Xorima <[email protected]>
Sent: Wednesday, June 12, 2019 12:13:19 PM
To: sous-chefs/snort
Cc: Simon Gill; Author
Subject: Re: [sous-chefs/snort] Enables testing with kitchen-dokken for some of the supported OSes. (#26)
Needs some updating to use the right platforms and the new orb.
See: #31<#31>
there are compile issues at the moment, need your assistance in resolving them :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#26?email_source=notifications&email_token=AAIFMADZKYOJPCPPCUOQ3FDP2DK47A5CNFSM4GMX5IBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQCCSY#issuecomment-501227851>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAIFMAD2NGJ3DKMD7JGIIWLP2DK47ANCNFSM4GMX5IBA>.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Updates metadata.rb to be clear about which versions of the platform are supported. Platforms and versions listed in metadata are also named in the kitchen config for vagrant. Platforms not supported have been removed from the dokken kitchen config. Everythings been rearranged to hopefully be more readable.
The CircleCI config now uses dokken-single from the sous-chef/kitchen orb instead of dokken. The latter pulls in the centos-6 image - which is pointless when RHEL6 variants aren't supported.
Issues Resolved
#25
Check List