Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables testing with kitchen-dokken for some of the supported OSes. #26

Closed
wants to merge 0 commits into from

Conversation

simonwgill
Copy link
Contributor

Description

Updates metadata.rb to be clear about which versions of the platform are supported. Platforms and versions listed in metadata are also named in the kitchen config for vagrant. Platforms not supported have been removed from the dokken kitchen config. Everythings been rearranged to hopefully be more readable.

The CircleCI config now uses dokken-single from the sous-chef/kitchen orb instead of dokken. The latter pulls in the centos-6 image - which is pointless when RHEL6 variants aren't supported.

Issues Resolved

#25

Check List

@xorima xorima requested a review from a team January 1, 2019 18:24
.kitchen.yml Outdated
- name: centos-7
- name: redhat-7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centos-7 should/does cover redhat-7. We don't tend to test using this as it isn't available as a dokken or Vagrant image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shooooould, but I've had some issues with my testing on the EC2 provider with package inconsistencies between variants. RHEL-7 fails to install libdnet and libdnet-devel, where CentOS 7 is perfectly happy.

I take the point about Vagrant though, I haven't been checking that it would work since I broke my work desktop with too many kitchen instances running at once.

.kitchen.dokken.yml Outdated Show resolved Hide resolved
platform: fedora-27
requires: [ danger, lint ]
- kitchen/dokken-single:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kitchen/dokken covers most of these platforms for less yaml :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but it also includes centos-6, which will break the check. I don't know if there's a way to have a loop in this yaml - so platform: [ centos-7, fedora-27, ubuntu-1804 ] and didn't want to burn too many cycles on that at this point.

Also this way there's also a number of dokken jobs which can be parallelized and reported separately. Minor thing, but I've found it helpful.

@damacus
Copy link
Member

damacus commented Jan 1, 2019

This is an awesome start.

For reference
the kitchen/dokken orb is here (which you might want to use:
https://github.com/sous-chefs/orbs/blob/master/orb.yml#L33-L73

@damacus damacus requested a review from xorima June 12, 2019 11:06
Copy link
Member

@damacus damacus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some updating to use the right platforms and the new orb.

@xorima
Copy link
Contributor

xorima commented Jun 12, 2019

Needs some updating to use the right platforms and the new orb.

See: #31
there are compile issues at the moment, need your assistance in resolving them :)

@simonwgill
Copy link
Contributor Author

simonwgill commented Jun 12, 2019 via email

@lock
Copy link

lock bot commented Oct 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants