-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated PR: Cookstyle Changes #64
Open
kitchen-porter
wants to merge
5
commits into
main
Choose a base branch
from
automated/cookstyle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues found and resolved with: resources/compile.rb - 72:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass Issues found and resolved with: resources/install.rb - 127:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass Issues found and resolved with: resources/rules.rb - 18:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass Issues found and resolved with: resources/service.rb - 5:26 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper - 18:77 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper - 30:26 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper - 44:77 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper - 48:1 refactor: Chef/Modernize/ClassEvalActionClass - In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass - 50:8 refactor: Chef/Modernize/UseChefLanguageSystemdHelper - Chef Infra Client 15.5 and later include a systemd? helper for checking if a Linux system uses systemd. https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper Signed-off-by: kitchen-porter <[email protected]>
Generated by 🚫 Danger |
damacus
added
the
Release: Major
Release to Chef Supermarket as a major change when merged
label
Feb 17, 2022
Signed-off-by: Dan Webb <[email protected]>
Signed-off-by: Dan Webb <[email protected]>
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
previously approved these changes
Sep 29, 2023
damacus
force-pushed
the
automated/cookstyle
branch
from
October 3, 2023 12:45
3961b17
to
543138b
Compare
Signed-off-by: Dan Webb <[email protected]>
damacus
force-pushed
the
automated/cookstyle
branch
from
October 3, 2023 12:46
543138b
to
c8fad75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I ran Cookstyle 7.25.6 against this repo and here are the results.
This repo was selected due to the topics of chef-cookbook
Changes
Issues found and resolved with resources/compile.rb
Chef/Modernize/ClassEvalActionClass
- In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)Issues found and resolved with resources/install.rb
Chef/Modernize/ClassEvalActionClass
- In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)Issues found and resolved with resources/rules.rb
Chef/Modernize/ClassEvalActionClass
- In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)Issues found and resolved with resources/service.rb
Chef/Modernize/UseChefLanguageSystemdHelper
- Chef Infra Client 15.5 and later include asystemd?
helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)Chef/Modernize/UseChefLanguageSystemdHelper
- Chef Infra Client 15.5 and later include asystemd?
helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)Chef/Modernize/UseChefLanguageSystemdHelper
- Chef Infra Client 15.5 and later include asystemd?
helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)Chef/Modernize/UseChefLanguageSystemdHelper
- Chef Infra Client 15.5 and later include asystemd?
helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)Chef/Modernize/ClassEvalActionClass
- In Chef Infra Client 12.9 and later it is no longer necessary to call the class_eval method on the action class block. (https://docs.chef.io/workstation/cookstyle/chef_modernize_classevalactionclass)Chef/Modernize/UseChefLanguageSystemdHelper
- Chef Infra Client 15.5 and later include asystemd?
helper for checking if a Linux system uses systemd. (https://docs.chef.io/workstation/cookstyle/chef_modernize_usecheflanguagesystemdhelper)