-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.0 Introduce client Clone task #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind to share the flaky error happening sometimes (when the race condition happens or like)?
I cannot reproduce it on my machine.
mix clone phase_id "token" | ||
|
||
""" | ||
|> Logger.warning() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mix.shell.info/1
makes it fancier, see this for an inspiration.
lib/umwelt/client/clone.ex
Outdated
defmodule Umwelt.Client.Clone do | ||
@moduledoc "Clone main process" | ||
|
||
use GenServer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use GenServer | |
use GenServer, restart: :transient, shutdown: 10_000 |
Default for :restart
is :permanent
and I doubt restarting makes any sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this change fixed both tests.
UPD: it wasn't .
lib/umwelt/client/writer.ex
Outdated
alias Umwelt.Client | ||
|
||
def start_link(module) do | ||
Task.start_link(__MODULE__, :run, [module]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task.Supervisor
would probably help to make sure all tasks are finished normally.
"Disco": "1", | ||
"Disco.Chaos": "2", | ||
"Disco.Discord": "3" | ||
}})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot believe formatter
did not say anything here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it did not.Maybe sigil ~s
allows this kind of format?
one:
two:
|
Captured failing test on CI! |
0d1fa08
to
4168e65
Compare
It seems some timers fix the issue. |
No description provided.